implemented sending of notifications based on segments (included/excluded)#72
Merged
LKaemmerling merged 4 commits intoAug 16, 2018
Conversation
Collaborator
|
Could you please rebase this on the refactor-to-traits branch? |
Author
|
I have done that, ... the current branch is up to date |
Collaborator
|
For me this looks okay @Lloople what do you think? |
Lloople
approved these changes
Aug 8, 2018
Collaborator
Lloople
left a comment
Lloople
left a comment
There was a problem hiding this comment.
It looks good to me. I personally don't like to align array values when multiline but I'm okay with it and it's totally aesthetic. Both method for include or exclude segments looks great 👍
LKaemmerling
merged commit 32521dd
into
laravel-notification-channels:refactor-to-traits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ability of users to send notifications excluding a segment i.e
public function routeNotificationForOneSignal() { return ['excluded_segments' => ['excluded segments']]; }ability of users to send notifications including a segment i.e
public function routeNotificationForOneSignal() { return ['included_segments' => ['included segments']]; }